fix: do not include full path to binary in .sha512 files #1108
Conversation
See ipfs/kubo#9323. This is a darwin release thing because the signature process for macOS means that we recalculate sha512 and cid and we do this using an absolute path so the result includes the path to the file. The fix is to cd to the folder and do it from there.
|
This change produced no new differences in built artifacts. |
|
Thanks! I'll try to test. Manually dispatched https://github.com/ipfs/distributions/actions/workflows/main.yml Update: we had a bug (116dfe2), will fix and retry. Update: 0.32.0-rc2 builds, let's wait until this CI run is done. |
name did not match one used in DIST_ROOT section (cherry picked from commit a00d71e)
There was a problem hiding this comment.
lgtm, https://github.com/ipfs/distributions/actions/runs/11750043494/job/32738190122#step:9:10 produced DAG with expected value:
$ ipfs cat /ipfs/Qmbu8BBcVVT6JpnQWssMwmzGaD6YQeB8XV7PtU4yp1BgNo/kubo/v0.32.0-rc2/kubo_v0.32.0-rc2_darwin-amd64.tar.gz.sha512
dccbd57d1d66e9cb95845c9b251d4b190771141451f50bb4e88710f4e4d869356a916de0f5ef14ec23f633865c88451194a2565036fac929bd2339424cde167b kubo_v0.32.0-rc2_darwin-amd64.tar.gz
Merging so the fix is applied when we release Kubo 0.32.0 next week.
lidel
changed the title
See ipfs/kubo#9323.
This is a darwin release thing because the signature process for macOS means that we recalculate sha512 and cid and we do this using an absolute path so the result includes the path to the file.
The fix is to cd to the folder and do it from there.