-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migration from 15 to 16 #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly copy & paste
10 tasks
lidel
commented
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ This PR includes a lot of boilerplate, but the only code that changed is in fs-repo-15-to-16/migration.go
+ tests in fs-repo-15-to-16/test-e2e
this way we see if latest migration e2e passes, before we hit any issues with legacy tooling tests, which is takes second place inpriority of things
lidel
commented
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- CI is green, was failing due to 504 from the public gateway.
- I've added explicit redirect from
dist-ipfs-[io|tech].ipns.dweb.link
todist.ipfs.tech
so legacy tests hit the correct infrastructure right away, rather than going via a proxy.
- I've added explicit redirect from
- The code in PR here is 99% copy&paste from previous migration, so not much to review, just a lot of boilerplate.
- Merging, will now open PR against https://github.com/ipfs/distributions which will produce a CID that I can use for end-to-end testing in Kubo against real public gateway URLs and IPFS routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds config migration that appends
/webrtc-direct
everywhere where UDP/quic-v1$
listener is already present.Context: ipfs/kubo#10463
fs-repo-15-to-16/migration.go