Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration from 15 to 16 #190

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat: migration from 15 to 16 #190

merged 4 commits into from
Aug 2, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 1, 2024

This PR adds config migration that appends /webrtc-direct everywhere where UDP /quic-v1$ listener is already present.

Context: ipfs/kubo#10463

  • migration and reverse migration in fs-repo-15-to-16/migration.go
  • tests in fs-repo-15-to-16/test-e2e
  • CI is green

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This PR includes a lot of boilerplate, but the only code that changed is in fs-repo-15-to-16/migration.go + tests in fs-repo-15-to-16/test-e2e

@lidel lidel marked this pull request as ready for review August 2, 2024 13:55
this way we see if latest migration e2e passes, before we hit any issues
with legacy tooling tests, which is takes second place inpriority
of things
Copy link
Member Author

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI is green, was failing due to 504 from the public gateway.
    • I've added explicit redirect from dist-ipfs-[io|tech].ipns.dweb.link to dist.ipfs.tech so legacy tests hit the correct infrastructure right away, rather than going via a proxy.
  • The code in PR here is 99% copy&paste from previous migration, so not much to review, just a lot of boilerplate.
    • Merging, will now open PR against https://github.com/ipfs/distributions which will produce a CID that I can use for end-to-end testing in Kubo against real public gateway URLs and IPFS routing.

@lidel lidel merged commit 64d9993 into master Aug 2, 2024
1 check passed
@lidel lidel deleted the fs-repo-15-to-16 branch August 2, 2024 14:07
lidel added a commit to ipfs/kubo that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant