Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Added config for dns-server patch #40

Closed
wants to merge 3 commits into from

Conversation

ItalyPaleAle
Copy link

This patch is required for ipfs/kubo#6560

@lidel
Copy link
Member

lidel commented Aug 12, 2019

This is awesome, thank you for working on this!

I imagine we will want to support more than one DNS Resolver, to make it more robust:

  • is the end goal to support both string and array of strings?
  • what will be the policy when more than one addr is provided?
    try them in order/round-robin if the first one fails?

@ItalyPaleAle
Copy link
Author

@lidel do you mind discussing the PR in ipfs/kubo#6560 to avoid forking?

I was not planning to add support for multiple DNS servers. Why do you think it's important - for HA?

My rationale for this PR was mostly to be able to support DNS servers running on localhost (which I believe includes TOR users too, according to an issue) and to support DNS-over-TLS servers like 1.1.1.1. Assuming that the DNS server on localhost is always up (by definition), for servers like Cloudflare's or Google's, they use multicast IP and they are incredibly reliable, and I think it's safe to assume they have 100% uptime. I believe that the idea of having multiple DNS resolvers is mostly a legacy thing and it's only applicable to those running DNS in corporate environments (like Active Directory) at this point.

But happy to discuss this :)

@matyapiro31
Copy link

I think this opttion is necessary for what I want to do.
I'm building custom dns server of OpenNIC domains, but to change all settings of server dns isn't good option.

@lidel lidel closed this Mar 9, 2022
@lidel
Copy link
Member

lidel commented Mar 9, 2022

I dont think this is needed anymore, since we have https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#dns 👍

FYSA go-ipfs-config got merged into go-ipfs repo: https://github.com/ipfs/go-ipfs/tree/master/config
If you feel this PR is still relevant, please reopen as a PR against go-ipfs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants