Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: go-libipfs #100

Closed
wants to merge 2 commits into from
Closed

bump: go-libipfs #100

wants to merge 2 commits into from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 20, 2023

This includes ipfs/boxo#206. This is needed because of the interfaces issues when trying to use go-libipfs/blockservice as go-blockservice/blockservice this fails to compile:

cannot use bserv (variable of type "github.com/ipfs/go-libipfs/blockservice".BlockService) as "github.com/ipfs/go-blockservice".BlockService value in argument to mdag.NewDAGService: "github.com/ipfs/go-libipfs/blockservice".BlockService does not implement "github.com/ipfs/go-blockservice".BlockService (wrong type for method Blockstore)
		have Blockstore() "github.com/ipfs/go-libipfs/blockstore".Blockstore
		want Blockstore() "github.com/ipfs/go-ipfs-blockstore".Blockstore

See:

An other alternative is to move go-merkledag and go-car into github.com/ipfs/go-libipfs/*, this would keep this repo as-is.
I've sent this because go-car already use go-libipfs for go-libipfs/blocks: https://github.com/ipld/go-car/blob/794f22231c0526e1123ee2a11bbc1567f9a011ae/go.mod#L9
I can submit the other option if you want.

@Jorropo Jorropo requested a review from rvagg March 20, 2023 13:05
@ipfs ipfs deleted a comment from welcome bot Mar 20, 2023
@github-actions
Copy link

Suggested version: v0.11.0

Comparing to: v0.10.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 4b3ca8f..8937a06 100644
--- a/go.mod
+++ b/go.mod
@@ -81,9 +81,9 @@ require (
 	go.uber.org/zap v1.22.0 // indirect
 	golang.org/x/crypto v0.0.0-20220525230936-793ad666bf5e // indirect
 	golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
-	golang.org/x/net v0.0.0-20220812174116-3211cb980234 // indirect
+	golang.org/x/net v0.7.0 // indirect
 	golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4 // indirect
-	golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab // indirect
+	golang.org/x/sys v0.5.0 // indirect
 	golang.org/x/tools v0.1.12 // indirect
 	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
 	google.golang.org/protobuf v1.28.1 // indirect

gorelease says:

# summary
Suggested version: v0.11.0

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported.
If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.11.0 manually.
The draft GitHub Release is going to be published when this PR is merged.
If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.

github.com/ipfs/go-ipld-cbor v0.0.6
github.com/ipfs/go-ipld-format v0.4.0
github.com/ipfs/go-ipld-legacy v0.1.1
github.com/ipfs/go-libipfs v0.6.3-0.20230320124707-517c64d18ad0
Copy link
Contributor Author

@Jorropo Jorropo Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change to a tag once this is merged in go-libipfs (I can't do this now because this is a module cycle).
I'll have to do this change in a new PR, because this is blocking the go-libipfs PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant