Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitswap check err.name in peer-want-lists/ledger #588

Closed
wants to merge 1 commit into from

Conversation

dozyio
Copy link

@dozyio dozyio commented Aug 31, 2024

Description

Was hitting a weird edge case where err.code is not set. Adding an additional check for err.name fixes the issue.

I was only hitting the edge case with 3+ nodes using MemoryDatastore, 2 nodes seemed fine.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@dozyio dozyio requested a review from a team as a code owner August 31, 2024 13:30
@dozyio
Copy link
Author

dozyio commented Aug 31, 2024

Not sure if you want to close this PR - didn't see #585 when I stated debugging

@achingbrain
Copy link
Member

Thanks for opening this - it's been fixed upstream by ipfs/js-stores#320 so the breakage should be over now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants