Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: made the kubo version param CI workflow uses configurable #2032

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Sep 27, 2022

I propose to make kubo version used during CI workflow run configurable.

This would enable running the CI workflow for a specific kubo release. In particular, we could include a testing step in the release checklist that asks the release lead to kick off CI workflow in ipfs-webui to test if the new kubo release is OK.

Testing

This is related to ipfs/kubo#9237

@welcome
Copy link

welcome bot commented Sep 27, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@galargh galargh marked this pull request as ready for review September 27, 2022 12:48
@galargh galargh requested a review from a team as a code owner September 27, 2022 12:48
@galargh galargh temporarily deployed to Deploy September 27, 2022 12:52 Inactive
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@SgtPooki SgtPooki temporarily deployed to Deploy October 4, 2022 23:06 Inactive
@hacdias hacdias merged commit 90b5f3a into main Oct 5, 2022
@hacdias hacdias deleted the ci/configurable-version-params branch October 5, 2022 09:24
@lidel
Copy link
Member

lidel commented Oct 14, 2022

@galargh this is not enough for E2E tests to run against new Kubo version.
ipfs/download-ipfs-distribution-action is used only for publishing ipfs-webui to IPFS and pinning to cluster, not testing it.

You either need to update go-ipfs dependency in package.json, or set IPFS_GO_EXEC env variable to the location of alternative ipfs binary

@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@galargh
Copy link
Contributor Author

galargh commented Nov 10, 2022

@galargh this is not enough for E2E tests to run against new Kubo version. ipfs/download-ipfs-distribution-action is used only for publishing ipfs-webui to IPFS and pinning to cluster, not testing it.

You either need to update go-ipfs dependency in package.json, or set IPFS_GO_EXEC env variable to the location of alternative ipfs binary

Good callout. We might not need this change at all then. I'll come up with a better way to test it during the next Kubo release.

galargh added a commit that referenced this pull request Nov 15, 2022
lidel pushed a commit that referenced this pull request Nov 15, 2022
This reverts commit 90b5f3a, see rationale in 
#2032 (comment)
ipfs-gui-bot pushed a commit that referenced this pull request Dec 9, 2022
## [2.21.0](v2.20.0...v2.21.0) (2022-12-09)

 CID `bafybeiequgo72mrvuml56j4gk7crewig5bavumrrzhkqbim6b3s2yqi7ty`

 ---

### Features

* use direct links to download all files ([#1894](#1894)) ([d1bcbbf](d1bcbbf))

### Bug Fixes

* support /quic-v1 ([#2073](#2073)) ([04eb7b3](04eb7b3))

### Trivial Changes

* bump playwright deps ([#2066](#2066)) ([f138960](f138960))
* **ci:** fix flaky unit test ([#2068](#2068)) ([bd038cd](bd038cd)), closes [/github.com//issues/2065#issuecomment-1315933342](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2065/issues/issuecomment-1315933342)
* Pull transifex translations ([#2069](#2069)) ([36f3641](36f3641))
* revert [#2032](#2032) ([#2064](#2064)) ([9473d7d](9473d7d)), closes [/github.com//pull/2032#issuecomment-1278928440](https://github.com/ipfs//github.com/ipfs/ipfs-webui/pull/2032/issues/issuecomment-1278928440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants