-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: made the kubo version param CI workflow uses configurable #2032
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
@galargh this is not enough for E2E tests to run against new Kubo version. You either need to update |
🎉 This PR is included in version 2.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Good callout. We might not need this change at all then. I'll come up with a better way to test it during the next Kubo release. |
This reverts commit 90b5f3a, see rationale in #2032 (comment)
## [2.21.0](v2.20.0...v2.21.0) (2022-12-09) CID `bafybeiequgo72mrvuml56j4gk7crewig5bavumrrzhkqbim6b3s2yqi7ty` --- ### Features * use direct links to download all files ([#1894](#1894)) ([d1bcbbf](d1bcbbf)) ### Bug Fixes * support /quic-v1 ([#2073](#2073)) ([04eb7b3](04eb7b3)) ### Trivial Changes * bump playwright deps ([#2066](#2066)) ([f138960](f138960)) * **ci:** fix flaky unit test ([#2068](#2068)) ([bd038cd](bd038cd)), closes [/github.com//issues/2065#issuecomment-1315933342](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2065/issues/issuecomment-1315933342) * Pull transifex translations ([#2069](#2069)) ([36f3641](36f3641)) * revert [#2032](#2032) ([#2064](#2064)) ([9473d7d](9473d7d)), closes [/github.com//pull/2032#issuecomment-1278928440](https://github.com/ipfs//github.com/ipfs/ipfs-webui/pull/2032/issues/issuecomment-1278928440)
I propose to make kubo version used during CI workflow run configurable.
This would enable running the CI workflow for a specific kubo release. In particular, we could include a testing step in the release checklist that asks the release lead to kick off CI workflow in
ipfs-webui
to test if the new kubo release is OK.Testing
This is related to ipfs/kubo#9237