-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-libp2p-kad-dht #10116
Conversation
2023-09-05 maintainer conversation: add changelog entry that links to probelab analysis on this in the past and can say that latency is expected to improve. |
@yiannisbot or @dennis-tra : I'd like to get in either the Kubo changelog about the expected DHT latency improvements with having multiaddrs in more responses. I assume there is past work / research / analysis we can link to. Could you please drop some link(s)? Thanks! |
2023-09-07 conversation: we expect to update to a new go-libp2p-kad-dht which doesn't have the filtering fixes. If that blows up, we'll retract and use the same version as the last Kubo release. |
@BigLep, this is the study that suggested the DHT change: https://github.com/plprobelab/network-measurements/blob/master/results/rfm17.1-sharing-prs-with-multiaddresses.md We don't have specific numbers on the latency improvements. Conceptually, we expect a reduction in the number of secondary DHT lookups, which should substantially improve the performance. |
Also worth noting that we'll be monitoring performance changes through this plot: https://probelab.io/ipfsdht/#dht-lookup-performance-overall-plot |
@dennis-tra https://github.com/plprobelab/network-measurements/blob/master/results/rfm17.1-sharing-prs-with-multiaddresses.md does not suggest filtering private addresses. |
That's right. Taking the impact of private addresses into account is a more recent development that came up after that study finished. That study mainly focussed on keeping Multiaddresses around for a longer period of time. |
That part is staying in, I'm backporting this. |
What is staying in, and what are you backporting to where? I cannot follow. |
673df10
to
b19c1ed
Compare
b19c1ed
to
954fc55
Compare
954fc55
to
257c4af
Compare
I'm removing skip/changelog since this need a changelog. |
@Jorropo : I was going to draft some changelog verbiage here, but it's not immediately clear to me what is or isn't happening in this kad-dht release vs. what Kubo had previously. Please go ahead and add. |
de404d3
to
a362053
Compare
This was ported in 579175f but we forgot to remove it.
ae85a6b
to
1c27cda
Compare
e1971bf
to
d7bcff0
Compare
No description provided.