docs: release process updates from v0.17.0 #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Making some changes that am seeing so far. Some of these changes are so I can leave PR comments.
BigLep
reviewed
Nov 10, 2022
There was a problem hiding this comment.
Thanks for starting this.
A couple of things:
- The PR title of "docs: release v0.17.0" confused me a little. I didn't immediately map it to "release process updates from 0.17.0". I thought it might more generic a docs updates for 0.17 (not just about our release process). Maybe rename to "docs: release process updates from 0.17.0" for clarity?
- I think we need to tighten up steps around our changelog. I don't see anything that is making sure the changelog is filled in. For example, what we have right now doesn't hit on the highlights. I think ideally we should do this before the RC, or else it's really unclear for anyone why they should try out the RC.
| @@ -14,7 +14,7 @@ | |||
| * Release reviewer: @who | |||
| * Expected RC date: week of YYYY-MM-DD | |||
| * 🚢 Expected final release date: YYYY-MM-DD | |||
| * Accompanying PR for improving the release process: (example: https://github.com/ipfs/kubo/pull/9100) | |||
There was a problem hiding this comment.
I am linking to this PR because we'll use it to set the right template in terms of PR title and description.
| @@ -108,7 +111,7 @@ Checklist: | |||
| - [ ] IPFS Discord #ipfs-chatter | |||
| - [ ] FIL Slack #ipfs-chatter | |||
| - [ ] Matrix https://matrix.to/#/#ipfs-chatter:ipfs.io | |||
| - [ ] Mention [early testers](https://github.com/ipfs/go-ipfs/tree/master/docs/EARLY_TESTERS.md) in the comment under the release issue ([example](https://github.com/ipfs/kubo/issues/9237#issuecomment-1258072509)). | |||
| - [ ] Mention [early testers](https://github.com/ipfs/go-ipfs/tree/master/docs/EARLY_TESTERS.md) in the comment under the release issue ([example](https://github.com/ipfs/kubo/issues/9319#issuecomment-1311002478)). | |||
There was a problem hiding this comment.
I updated the link because in the latest comment I added context for why folks were being pinged and how they get removed.
For example, while @b5 is still absolutely in the community, QRI is no-more and I don't think need to be pinged about Kubo releases.
galargh
changed the title
galargh
force-pushed
the
docs-release-v0.17.0
branch
from
b991450 to
5ff08e4
Compare
galargh
commented
Dec 5, 2022
galargh
commented
Dec 5, 2022
galargh
commented
Dec 5, 2022
galargh
commented
Dec 5, 2022
| - [ ] **Stage 3 - Internal Testing** | ||
| - [ ] Library Testing. |
There was a problem hiding this comment.
We test these in Kubo CI.
galargh
commented
Dec 5, 2022
| - [ ] Update the draft PR created for [interop](https://github.com/ipfs/interop) to use the new release and mark it as ready for review. | ||
| - [ ] Update the draft PR created for [IPFS Desktop](https://github.com/ipfs-shipyard/ipfs-desktop) to use the new release and mark it as ready for review. | ||
| - [ ] Update docs | ||
| - [ ] Run https://github.com/ipfs/ipfs-docs/actions/workflows/update-on-new-ipfs-tag.yml to generate a PR to the docs repo | ||
| - [ ] Merge the auto-created PR in https://github.com/ipfs/ipfs-docs/pulls ([example](https://github.com/ipfs/ipfs-docs/pull/1263)) | ||
| - [ ] Get the blog post created and shared | ||
| - [ ] Get the blog post created |
There was a problem hiding this comment.
There is no way to link to the blogpost as it's just a redirect to the GitHub release.
|
I removed my raw notes from the issue template - 4d1d0b7. I don't think we need them here in this form. I'm going to use them to create more user-friendly automation during 0.18. |
ajnavarro
approved these changes
Dec 5, 2022
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for capturing improvements to the release process as we go.
This accompanies #9319