fix: User-Agent sent to IPNI HTTP routers #9550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Jan 14, 2023
lidel
force-pushed
the
fix/delegated-routing-user-agent-header
branch
from
296869b to
28b92f0
Compare
willscott
approved these changes
Jan 14, 2023
lidel
commented
Jan 14, 2023
Closed
|
Agreed we should have this - good catch. |
ajnavarro
approved these changes
Jan 17, 2023
ajnavarro
reviewed
Jan 17, 2023
| ipfs block stat "$WANT_CID" & | ||
| test_wait_output_n_lines_60_sec http_requests 3 && | ||
| test_should_contain "GET /routing/v1/providers/$WANT_CID" http_requests | ||
| ' | ||
|
|
||
| test_expect_success 'expect HTTP request User-Agent to match Kubo version' ' |
There was a problem hiding this comment.
would be nice to add this using the new sharness go framework.
There was a problem hiding this comment.
Yes, extracted to #9562 so test refactor does not block 0.18
lidel
force-pushed
the
fix/delegated-routing-user-agent-header
branch
from
c561c4f to
6030db6
Compare
lidel
commented
Jan 17, 2023
lidel
force-pushed
the
fix/delegated-routing-user-agent-header
branch
2 times, most recently
from
e5dcd4b to
9088989
Compare
lidel
force-pushed
the
fix/delegated-routing-user-agent-header
branch
from
9088989 to
da625cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets correct
User-Agentheader sent to remote HTTP routers / IPNIs (like cid.contact):See ipfs/boxo#17 and ipfs/boxo#31
TODO
ipfs id -f "<aver>\n"