-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): ipfs-interop and ipfs-webui #9570
Conversation
b59c39f
to
838aaeb
Compare
5e552d6
to
dbf614e
Compare
@achingbrain did you see any of the errors from here before? |
@lidel not specifically but from the error messages I think some deps need updating to the latest versions. |
FYSA |
62fc552
to
27f390a
Compare
.circleci/main.yml
Outdated
@@ -26,6 +26,7 @@ aliases: | |||
- ~/.cache/go-build/ | |||
|
|||
default_environment: &default_environment | |||
GO_IPFS_DIST_URL: https://dist-ipfs-tech.ipns.cf-ipfs.com # remove this line when https://github.com/protocol/bifrost-infra/issues/2300 is closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using CF gateway until https://github.com/protocol/bifrost-infra/issues/2300 is closed is ok, we only use it for tests.
27f390a
to
039d2f4
Compare
@galargh fysa: I've rebased this PR to only have For now, I am merging to fix CI on master and PRs |
This PR aims to fix circleci failrues, but also update to the lastest version.
TODO
Problems
const data = await got(`${distUrl}/go-ipfs/${version}/dist.json`).json()
which fails hereTried so far
GO_IPFS_DIST_URL
to avoid nodes with 0.18.0-rc2 bug → https://github.com/protocol/bifrost-infra/issues/2300#issuecomment-1398946009