Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ipfs-interop and ipfs-webui #9570

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(ci): ipfs-interop and ipfs-webui #9570

merged 1 commit into from
Jan 20, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 19, 2023

This PR aims to fix circleci failrues, but also update to the lastest version.

TODO

  • fix interop
  • fix webui

Problems

  • ipfs-interop fails to download libp2p-relay-daemon for the similar reason – json does not have expected field.
  • ipfs-webui fails due to npm-go-ipfs line: const data = await got(`${distUrl}/go-ipfs/${version}/dist.json`).json() which fails here

Tried so far

@lidel lidel self-assigned this Jan 19, 2023
@lidel lidel force-pushed the fix/js-interop-ci branch 3 times, most recently from b59c39f to 838aaeb Compare January 19, 2023 20:19
@lidel lidel changed the title fix(ci): ipfs-interop 10.0.0 fix(ci): ipfs-interop and ipfs-webui Jan 19, 2023
@lidel lidel force-pushed the fix/js-interop-ci branch 3 times, most recently from 5e552d6 to dbf614e Compare January 19, 2023 23:29
@lidel
Copy link
Member Author

lidel commented Jan 20, 2023

@achingbrain did you see any of the errors from here before?

2023-01-20-135826_1341x844_scrot

@achingbrain
Copy link
Member

@lidel not specifically but from the error messages I think some deps need updating to the latest versions.

@lidel
Copy link
Member Author

lidel commented Jan 20, 2023

FYSA TypeError: Cannot read properties of undefined (reading 'linux') is caused by 0.18.0-rc2 being deployed just recently to some gateway nodes, there is a bug which we fixed in #9566, details in https://github.com/protocol/bifrost-infra/issues/2300#issuecomment-1398946009

@lidel lidel force-pushed the fix/js-interop-ci branch from 62fc552 to 27f390a Compare January 20, 2023 21:51
@@ -26,6 +26,7 @@ aliases:
- ~/.cache/go-build/

default_environment: &default_environment
GO_IPFS_DIST_URL: https://dist-ipfs-tech.ipns.cf-ipfs.com # remove this line when https://github.com/protocol/bifrost-infra/issues/2300 is closed
Copy link
Member Author

@lidel lidel Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using CF gateway until https://github.com/protocol/bifrost-infra/issues/2300 is closed is ok, we only use it for tests.

@lidel lidel force-pushed the fix/js-interop-ci branch from 27f390a to 039d2f4 Compare January 20, 2023 22:07
@lidel lidel marked this pull request as ready for review January 20, 2023 23:29
@lidel
Copy link
Member Author

lidel commented Jan 20, 2023

@galargh fysa: I've rebased this PR to only have GO_IPFS_DIST_URL fix. We can remove it after 0.18 ships, is deployed to gateways, and https://github.com/protocol/bifrost-infra/issues/2300 is closed.

For now, I am merging to fix CI on master and PRs

@lidel lidel merged commit ad9b486 into master Jan 20, 2023
@lidel lidel deleted the fix/js-interop-ci branch January 20, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants