Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove writable gateway #9743

Merged
merged 5 commits into from
Mar 27, 2023
Merged

feat: remove writable gateway #9743

merged 5 commits into from
Mar 27, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 21, 2023

Completely removes the writable gateway, closes #9738.

It was already deprecating and we were already pointing users at the new IPIP PR. Therefore, I decided to remove it completely and mark it as removed in the documentation.

I think that keeping the option there, as per #9738 (comment), could generate confusion, since it would be between a deprecated and removed state that would not be clear.

@hacdias hacdias self-assigned this Mar 21, 2023
@hacdias hacdias marked this pull request as ready for review March 21, 2023 09:19
@hacdias hacdias requested a review from lidel as a code owner March 21, 2023 09:19
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

before we merge, we need to add log.Fatal so users which have Gateway.Writable: true get clear, actionable error pointing at ipfs/specs#375

core/corehttp/gateway.go Show resolved Hide resolved
config/gateway.go Outdated Show resolved Hide resolved
@hacdias hacdias requested a review from lidel March 22, 2023 16:36
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 I think sharness timeouts because I've changed the stdout for Gateway and RPC API, and something is naively grepping for old strings. If we don't circle back to this, and want to ship deprecation with Kubo 0.20 rc1, fine to undo 17b5649 for now and restore (readonly).

hacdias and others added 5 commits March 27, 2023 13:35
- (readonly) is confusing since we have Gateway.NoFetch - better to
  remove it from stdout
- more actionable error message and docs
- removed (readonly) from gateway (less confusing that having that and
  Gateway.NoFetch:true at the same time)
- RPC API instead of plain API
@hacdias
Copy link
Member Author

hacdias commented Mar 27, 2023

@lidel sharness was timing out everywhere and was fixed on #9755. I just rebased and it works fine now.

@hacdias hacdias requested a review from lidel March 27, 2023 11:48
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much red lines, I love it.

@hacdias hacdias merged commit 88d431c into master Mar 27, 2023
@hacdias hacdias deleted the issue/9738 branch March 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove Writable Gateway
3 participants