-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade from go-block-format to go-libipfs/blocks #356
Conversation
@hacdias you just need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests still seem unhappy |
Yeah there is two go.mod files and there were a typo in one of the files. Fixed it. Edit: no more things to fix :'( |
3 even, right? (v1, v2, and cmd) |
Right, |
@Jorropo in a perfect world, we would also have updated https://github.com/ipfs/go-merkledag which go-car depends on, but this is also fine. |
@hacdias in a perfect world Using stubs is fine, open a PR on https://github.com/ipfs/go-merkledag if you want to update it. |
For the record, per conversation in ipfs/boxo#218, it is acknowledged by PL EngRes IPFS Stewards that it was wrong a mistake to merge this PR without having maintainer approval (e.g., someone from Bedrock). Apologies to those impacted and for the trust that was tarnished. It is going to get reverted shortly by @Jorropo . |
go-block-format
is now deprecated: ipfs/go-block-format#37It seems like other dependencies have to be updated in order for this to work and they will also be incorporated into go-libipfs. I will update this PR once that is the case.