STYLE: reduced slider indicators and added a hook for reduced motion preference #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes the following styling changes to the Slider component:
I also included a
usePrefersReducedMotionhook which will disable the animation for the users who have system preferences set to Reduce Motion (users who opt out of animation). See here for the article.How to test Reduce Motion?
Enable Reduce Motion settings, and check if the animation is disabled. Otherwise the animation should be enabled. Instruction where to find Reduce Motion settings.
Visuals
Before implementation
After implementation
Reduced motion implementation
CleanShot.2024-04-09.at.15.21.37.mp4