Separate encrypted and non-encrypted paths #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead.
gammazero
added a commit
to ipni/indexstar
that referenced
this pull request
Aug 29, 2023
Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead. Fixes #127 Requires ipni/dhstore#84
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 57.08% 57.87% +0.79%
==========================================
Files 12 12
Lines 925 940 +15
==========================================
+ Hits 528 544 +16
+ Misses 353 352 -1
Partials 44 44
☔ View full report in Codecov by Sentry. |
willscott
approved these changes
Aug 29, 2023
…ash is dbl-sha2-256 and if not found fall back to uncrypted (dhfind) lookup. Logging not used in dhstore/pebble, errors logged by callers.
gammazero
force-pushed
the
separate-encrypted-path
branch
from
dc7421d to
54044ae
Compare
masih
approved these changes
Sep 8, 2023
gammazero
added a commit
to ipni/indexstar
that referenced
this pull request
Sep 9, 2023
* Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead. Requires ipni/dhstore#84 Fixes #127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on dbl-sha2-256 codec to determine if querying for encrypted or non-encrypted multihash. Use URL path instead.