Drop support for FindBatch API #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gammazero
commented
Sep 19, 2023
gammazero
commented
- Add FindBatch convenience fuinction
- Define common Finder interface to replace Interface
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 61.47% 61.42% -0.05%
==========================================
Files 57 57
Lines 4919 4913 -6
==========================================
- Hits 3024 3018 -6
Misses 1570 1570
Partials 325 325
☔ View full report in Codecov by Sentry. |
- Add FindBatch convenience fuinction - Define common Finder interface to replace Interface
gammazero
force-pushed
the
no-findbatch
branch
from
7d160df to
c103e4f
Compare
willscott
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.