Return same not-found response from dh and non-dh clients #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
force-pushed
the
no-error-when-not-found
branch
2 times, most recently
from
6f95b62 to
4bf4348
Compare
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 61.48% 61.48%
=======================================
Files 57 57
Lines 4913 4913
=======================================
Hits 3021 3021
Misses 1567 1567
Partials 325 325 ☔ View full report in Codecov by Sentry. |
The Client and DHashClient need to return the same response when no results are found. Return empty response for not found to preserve compatability with clients that expect non-nil response. Fixes #53
gammazero
force-pushed
the
no-error-when-not-found
branch
from
dd4d4a6 to
8ba0037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientandDHashClientneed to return the same response when no results are found. A not-found response is indicated by an emptyFindResponseand a nil error. A non-nilFindResponseis returned in order to preserve compatibility with existing clients that expect a non-nil value.Fixes #53