Check for no addrs before constructing syncer #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 61.90% 62.15% +0.25%
==========================================
Files 49 49
Lines 4318 4318
==========================================
+ Hits 2673 2684 +11
+ Misses 1347 1336 -11
Partials 298 298 ☔ View full report in Codecov by Sentry. |
masih
added a commit
that referenced
this pull request
Feb 14, 2024
Check for empty addrs earlier when instantiating syncer. Patch fix for v0.5.11. See #155 for fix on `main`.
gammazero
approved these changes
Feb 14, 2024
masih
added a commit
that referenced
this pull request
Feb 15, 2024
Check for empty addrs earlier when instantiating syncer or subscriber. Patch fix for v0.5.11. See #155 for fix on `main`.
masih
added a commit
that referenced
this pull request
Feb 15, 2024
Check for empty addrs earlier when instantiating syncer or subscriber. Patch fix for v0.5.11. See #155 for fix on `main`.
masih
added a commit
that referenced
this pull request
Feb 15, 2024
Check for empty addrs earlier when instantiating syncer or subscriber. Patch fix for v0.5.11. See #155 for fix on `main`.
Assert that a there are addresses associated to a remote peer before constructing a syncer.
masih
force-pushed
the
masih/fix-check-for-addrs
branch
from
ec072f2 to
95d53a9
Compare
masih
added a commit
that referenced
this pull request
Feb 15, 2024
Check for empty addrs earlier when instantiating syncer or subscriber. Patch fix for v0.5.11. See #155 for fix on `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that a there are addresses associated to a remote peer before constructing a syncer.