Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegated find path #166

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Fix delegated find path #166

merged 4 commits into from
Sep 20, 2023

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Sep 20, 2023

The delegated find path in delegated_translator.go was being was being formed incorrectly, and did not remove the "providers/" part of the path.

The fix was to change this:

uri := r.URL.JoinPath("../cid", cidUrlParam)

to this:

uri := r.URL.JoinPath("../../cid", cidUrlParam)

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (13bbd7d) 6.89% compared to head (1424049) 6.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #166      +/-   ##
========================================
- Coverage   6.89%   6.85%   -0.04%     
========================================
  Files         11      11              
  Lines       1349    1356       +7     
========================================
  Hits          93      93              
- Misses      1251    1258       +7     
  Partials       5       5              
Files Changed Coverage Δ
delegated_translator.go 0.00% <0.00%> (ø)
find.go 0.00% <0.00%> (ø)
find_ndjson.go 0.00% <0.00%> (ø)
providers.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Suggested version: v0.1.2

Comparing to: v0.1.1 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.sum: one or more sums are missing. Run 'go mod tidy' to add missing sums.

# summary
Suggested version: v0.1.2

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@gammazero gammazero merged commit 03785ff into main Sep 20, 2023
11 checks passed
@gammazero gammazero deleted the fix-delegated-find-path branch September 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants