-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document IPNI HTTP provider specification #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a good extraction of what we expect from the provider
7336659
to
fa68cd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent
It might be nice to leave open (and document here) the ability of announcement |
fa68cd2
to
91abdef
Compare
@rvagg thank you for pointing Can I ask you to give it a read and let me know what you think please? Also captured ipni/go-libipni#42 |
great! I've followed up in ipni/go-libipni#42 |
Doh - my original comment was in the wrong issue - my bad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't block on anything from me. Just left comments while reading through after it came up during the Content Routing WG on 2023-05-30. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masih added my usual comments about including explicit headers for HTTP Caching + some questions/concerns around /httpath
Rendered
Note: I have opted for least disruptive spec relative to the current implementation. If you folks think this doesn't matter as much there are things that I'd like to change.
Fixes #16