Fix shutdown failure after manual sync #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a manual synce request is given when there is already a sync in progress, the WaitGroup is being incremented even though a new goroutine is not started. This causes the server shutdown to hang waiting for the WaitGroup.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 46.72% 46.71% -0.02%
==========================================
Files 84 84
Lines 9960 9961 +1
==========================================
- Hits 4654 4653 -1
- Misses 4775 4776 +1
- Partials 531 532 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a manual synce request is given when there is already a sync in progress, the WaitGroup is being incremented even though a new goroutine is not started. This causes the server shutdown to hang waiting for the WaitGroup.