Support Ipni-Cid-Schema-Type HTTP header #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update go-libipni - Remove loadtest synthetic command that was never used - Update README
The Ipni-Cid-Schema-Type HTTP header serves as an indication to advertisement publishers what type of data is being requested and is identified by the CID. This may help some publishers more quickly lookup the data. - Remove `synthetic` command The synthetic command is not used as there is not longer a way to import the generated data. This command was originally used to populate storetheindex with artificial data for testing. Test data is readily available from providers and CAR mirrors, and can be made available by a reference index provider, so there is not a need to generate data synthetically withing a storetheindex admin command. Other changes: - Update go-libp2p, boxo - Update README to remove references to comands that no longer exist
gammazero
force-pushed
the
update-deps
branch
from
441430c to
039e8cd
Compare
gammazero
changed the title
masih
approved these changes
Sep 11, 2024
| @@ -137,11 +136,10 @@ func TestAssignerAll(t *testing.T) { | |||
| } | |||
| t.Log("Publisher", peer2IDStr, "assigned to indexer", assignNum) | |||
| assigns = append(assigns, assignNum) | |||
| case <-timeout.C: | |||
| case <-time.After(3 * time.Second): | |||
There was a problem hiding this comment.
What was the rationale for these changes? Would it be possible to use require.Eventually at the time of assertion to avoid fixed value waits?
There was a problem hiding this comment.
The rationale for this was because now (in go1.23) timers can be GC'd even if they are still running, so time.After means less code and no need to stop and reset timers and worry about semantics before and after go1.23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ipni-Cid-Schema-Type HTTP header serves as an indication to advertisement publishers what type of data is being requested and is identified by the CID. This may help some publishers more quickly lookup the data.
loadtest syntheticcommand that was never usedThe
syntheticcommand is not used as there is not longer a way to import the generated data. This command was originally used to populate storetheindex with artificial data for testing. Test data is readily available from providers and CAR mirrors, and can be made available by a reference index provider, so there is not a need to generate data synthetically withing a storetheindex admin command.Other changes:
Closes #2662