Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make public the ingest and registry #2680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alanshaw
Copy link

Context

I wanted to run an IPNI node locally, programmatically, for testing.

Proposed Changes

Make ingest and registry packages public.

Tests

No code added.

Revert Strategy

Change is safe to revert.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.69%. Comparing base (f74cf2a) to head (11216d0).
Report is 67 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
+ Coverage   42.85%   45.69%   +2.84%     
==========================================
  Files          96       94       -2     
  Lines       11436    11186     -250     
==========================================
+ Hits         4901     5112     +211     
+ Misses       5936     5462     -474     
- Partials      599      612      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masih masih requested a review from gammazero October 28, 2024 18:11
@gammazero
Copy link
Collaborator

@masih, @alanshaw
storetheindex is meant to be an application and not a library. I recommend that the ingestion/registry code be moved into another repo that is meant as a library, so that it can be maintained as such and not treated like an application for our own use.

I think the code should either move into ipni/go-libipni or into another new repo ipni/ingest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants