Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deps 9-18 & filter CI #319

Merged
merged 3 commits into from
Sep 19, 2023
Merged

chore: deps 9-18 & filter CI #319

merged 3 commits into from
Sep 19, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Sep 18, 2023

all deps into one and some CI filtering.

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner September 18, 2023 23:07
@zeeshanlakhani zeeshanlakhani changed the title chore: deps 9-18 chore: deps 9-18 & filter CI Sep 19, 2023
@@ -3432,7 +3432,7 @@
return
end
i32.const 0
i32.load8_u offset=1049029
i32.load8_u offset=1049028
Copy link
Member

@expede expede Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely out of curiosity: why did the offsets change? (there's a few and their values swapped)

Copy link
Contributor Author

@zeeshanlakhani zeeshanlakhani Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wit-bindgen update :).

Copy link
Member

@expede expede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks for the quick turn around @zeeshanlakhani

@zeeshanlakhani zeeshanlakhani merged commit 4463050 into main Sep 19, 2023
@zeeshanlakhani zeeshanlakhani deleted the zl/deps-9-18 branch September 19, 2023 02:21
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants