Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: general readme, development, example updates #344

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Oct 4, 2023

Description

Readme improvements. Related to #346.

@zeeshanlakhani zeeshanlakhani requested review from expede and bgins October 4, 2023 14:21
@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner October 4, 2023 14:21
@zeeshanlakhani zeeshanlakhani self-assigned this Oct 4, 2023
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a couple suggested edits.

DEVELOPMENT.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Comment on lines +74 to +79
Throughout the `homestar` ecosystem and documentation, we'll draw a distinction
between the [host runtime][host-runtime] and the support for different
[guest languages and bindings][guest]. If you're mainly interested in
learning how to write and build-out Wasm components (in Rust), please jump
into our [`homestar-functions`](./homestar-functions) directory
and check out our examples there.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great! 💯

README.md Outdated Show resolved Hide resolved
Zeeshan Lakhani and others added 3 commits October 4, 2023 11:46
suggestion: pre-commit.

Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
rm ""

Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
rm `detailed`

Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bmann bmann merged commit f068d8f into main Oct 4, 2023
15 checks passed
@bmann bmann deleted the zl/readme++ branch October 4, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants