-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPykernel 7 compatibility #895
Comments
Thanks, I think I can work on this this week. |
I think I've tracked it down to the incomplete assumption of async sockets in the updates to IOThread. Looking into more detail, but I think the fix belongs in ipykernel because there's a mixture of sync and async use of sockets, relying on the assumption that async zmq sends are eager and don't need to be awaited. |
I do trust you, I haven't followed what has append in ipykernel, and I'm mostly trying to not have everything fall appart. |
Looks like it's a little more complicated than that in that ipyparallel relied on support for |
Thinking out loud about how to address the single socket issue Two choices are:
I'm leaning toward the latter, which I think wouldn't need any change from ipykernel |
I was wrong about that, ipyparallel uses one socket connected to multiple URLs, so setting |
It looks like ipyparallel is not compatible with ipykernel 7,
Unfortunately I've not been following the development, and the previous maintainer stepped down a few month ago, and I'm afraid of the 6.x and 7.x branch diverging.
I would love to get some help get the downstream testing passing on all projects that depends on ipykernel.
cf ipython/ipykernel#1222
The text was updated successfully, but these errors were encountered: