fix mixture of sync/async sockets in IOPubThread #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all sockets are explicitly sync until/except we are in the coroutines that will await them - consistent behavior of send for child pipe and main process sockets - avoids unsafe assumption that send is greedy on async sockets - avoids potential issues creating async objects in one thread, then using them in another in a different event loop - always creates/uses the right types, regardless of input socket - address some typing lint
instead, keep same context but use `socket_class` kwarg to specify socket classes shadow context prevents cleanup of untracked sockets via ctx.destroy because it disconnects socket bookkeeping
minrk
force-pushed
the
sync-sockets-threads
branch
from
b1d0ed5
to
64ff5d4
Compare
|
ok, actually all correct now, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all sockets are explicitly sync until/except we are in the coroutines that will await them, whereas there was an ambiguous mixture of sync and async sockets before
found while working on ipython/ipyparallel#895