Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mixture of sync/async sockets in IOPubThread #1275

Merged
merged 5 commits into from
Oct 26, 2024

Commits on Oct 21, 2024

  1. fix mixture of sync/async sockets in IOPubThread

    all sockets are explicitly sync until/except we are in the coroutines that will await them
    
    - consistent behavior of send for child pipe and main process sockets
    - avoids unsafe assumption that send is greedy on async sockets
    - avoids potential issues creating async objects in one thread, then using them in another in a different event loop
    - always creates/uses the right types, regardless of input socket
    - address some typing lint
    minrk committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9ae6940 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    3b1188a View commit details
    Browse the repository at this point in the history
  2. avoid shadowing context

    instead, keep same context but use `socket_class` kwarg to specify socket classes
    
    shadow context prevents cleanup of untracked sockets via ctx.destroy because it disconnects socket bookkeeping
    minrk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    64ff5d4 View commit details
    Browse the repository at this point in the history
  3. unhelpful linter

    minrk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    53b2911 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    0ad07bb View commit details
    Browse the repository at this point in the history