[Substrait] Implement simple extensions. #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
substrait-simple-extensions
branch
6 times, most recently
from
df3bd1e
to
9b32ee5
Compare
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
substrait-simple-extensions
branch
from
9b32ee5
to
8fe00d2
Compare
ingomueller-net
force-pushed
the
substrait-simple-extensions
branch
2 times, most recently
from
5f7e841
to
662a78d
Compare
ingomueller-net
added a commit
to ingomueller-net/iree-llvm-sandbox
that referenced
this pull request
Jul 22, 2024
This allows to use the externally declared functions from iree-org#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
jpienaar
approved these changes
Jul 22, 2024
This is a mechanism of Substrait to define functions and types external to the core specification. This PR models the declarations as `Symbol`s and references to them as symbol references in MLIR, which allows to use MLIR tooling around symbols (such as `SymbolTable`s, iterating over symbol uses, code navigation via the LSP server, etc.). The PR does not yet implement a mechanism to use the functions and types, which subsequent PRs for `ScalarFunction` and similar are going to do. While touching the `PlanOp`-related test cases, this op also merges the tests of that op, which were previously split into a "simple" and a "version" file, which probably predates the possibility to tell `mlir-translate` (and custom variants) to use output splitters. Signed-off-by: Ingo Müller <ingomueller@google.com>
In the meantime, `main` contains tests that used `func.call` ops to prevent further pattern application. This breaks with this PR, which makes `plan`s a `SymbolTable`, which become the closest symbol table of the `func.call`s, such that those symbols cannot be found anymore. As a solution, this commit changes the unit tests to use an opaque op from an unregistered dialect. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
substrait-simple-extensions
branch
from
662a78d
to
35b8f45
Compare
ingomueller-net
added a commit
to ingomueller-net/iree-llvm-sandbox
that referenced
this pull request
Jul 31, 2024
This allows to use the externally declared functions from iree-org#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/iree-llvm-sandbox
that referenced
this pull request
Jul 31, 2024
This allows to use the externally declared functions from iree-org#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to ingomueller-net/iree-llvm-sandbox
that referenced
this pull request
Jul 31, 2024
This allows to use the externally declared functions from iree-org#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
that referenced
this pull request
Jul 31, 2024
This allows to use the externally declared functions from #853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
) This is a mechanism of Substrait to define functions and types external to the core specification. This PR models the declarations as `Symbol`s and references to them as symbol references in MLIR, which allows to use MLIR tooling around symbols (such as `SymbolTable`s, iterating over symbol uses, code navigation via the LSP server, etc.). The PR does not yet implement a mechanism to use the functions and types, which subsequent PRs for `ScalarFunction` and similar are going to do. In the meantime, `main` contains tests that used `func.call` ops to prevent further pattern application. This breaks with this PR, which makes `plan`s a `SymbolTable`, which become the closest symbol table of the `func.call`s, such that those symbols cannot be found anymore. As a solution, this PR also changes the unit tests to use an opaque op from an unregistered dialect. While touching the `PlanOp`-related test cases, this op also merges the tests of that op, which were previously split into a "simple" and a "version" file, which probably predates the possibility to tell `mlir-translate` (and custom variants) to use output splitters. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…g/iree-llvm-sandbox#855) This allows to use the externally declared functions from iree-org/iree-llvm-sandbox#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
) This is a mechanism of Substrait to define functions and types external to the core specification. This PR models the declarations as `Symbol`s and references to them as symbol references in MLIR, which allows to use MLIR tooling around symbols (such as `SymbolTable`s, iterating over symbol uses, code navigation via the LSP server, etc.). The PR does not yet implement a mechanism to use the functions and types, which subsequent PRs for `ScalarFunction` and similar are going to do. In the meantime, `main` contains tests that used `func.call` ops to prevent further pattern application. This breaks with this PR, which makes `plan`s a `SymbolTable`, which become the closest symbol table of the `func.call`s, such that those symbols cannot be found anymore. As a solution, this PR also changes the unit tests to use an opaque op from an unregistered dialect. While touching the `PlanOp`-related test cases, this op also merges the tests of that op, which were previously split into a "simple" and a "version" file, which probably predates the possibility to tell `mlir-translate` (and custom variants) to use output splitters. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…g/iree-llvm-sandbox#855) This allows to use the externally declared functions from iree-org/iree-llvm-sandbox#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mechanism of Substrait to define functions and types external
to the core specification. This PR models the declarations as
Symbolsand references to them as symbol references in MLIR, which allows to use
MLIR tooling around symbols (such as
SymbolTables, iterating oversymbol uses, code navigation via the LSP server, etc.). The PR does not
yet implement a mechanism to use the functions and types, which
subsequent PRs for
ScalarFunctionand similar are going to do.While touching the
PlanOp-related test cases, this op also merges thetests of that op, which were previously split into a "simple" and a
"version" file, which probably predates the possibility to tell
mlir-translate(and custom variants) to use output splitters.