Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Optimize bitset.all() #540

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Optimize bitset.all() #540

merged 3 commits into from
Aug 1, 2023

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Jul 29, 2023 •
edited
Loading

Add early return

@MBkkt MBkkt requested review from gnusi and Dronplane July 31, 2023 04:29
Dronplane
Dronplane reviewed Jul 31, 2023
View reviewed changes
core/utils/bitset.hpp Outdated Show resolved Hide resolved
@MBkkt @Dronplane
Update core/utils/bitset.hpp
0f31017 
Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>
Dronplane
Dronplane approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. But please add a test for counting last word, as look like this issue happens and we don't cover it with existing tests.

@MBkkt
Copy link
Contributor Author

MBkkt commented Aug 1, 2023

We already have such tests. It's all cases when bitset contains only 1 word

@MBkkt MBkkt merged commit e051faa into master Aug 1, 2023
1 check passed
@MBkkt MBkkt deleted the chore/optimize-bitset-all branch August 1, 2023 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dronplane Dronplane Dronplane approved these changes

@gnusi gnusi Awaiting requested review from gnusi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @Dronplane