Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

[APM-670] Memory accounting prepare and execute #542

Merged
merged 22 commits into from
Aug 15, 2023
Merged

[APM-670] Memory accounting prepare and execute #542

merged 22 commits into from
Aug 15, 2023

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Aug 2, 2023 •
edited
Loading

For execute only interface

boolean, granular_range, phrase, range, same_position

@MBkkt MBkkt requested review from gnusi and Dronplane August 2, 2023 23:40
Dronplane
Dronplane approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dronplane
Dronplane reviewed Aug 11, 2023
View reviewed changes
.clang-tidy Outdated Show resolved Hide resolved
Dronplane
Dronplane reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests for new functionality?

core/search/filter.hpp Show resolved Hide resolved
core/search/proxy_filter.cpp Outdated Show resolved Hide resolved
core/search/states_cache.hpp Outdated Show resolved Hide resolved
@Dronplane
Copy link
Contributor

Dronplane commented Aug 14, 2023 •
edited
Loading

Also woudl it be possible to account memory for filters added via boolean_filter::add<T, Args> ?

@MBkkt
Copy link
Contributor Author

MBkkt commented Aug 14, 2023

Also woudl it be possible to account memory for filters added via boolean_filter::add<T, Args> ?

We shouldn't because it's not prepare memory, also it restricted by size of plan, compared to prepared statements which depend on data

@MBkkt MBkkt changed the title [APM-670] Create interface for memory accounting prepared and filter [APM-670] Memory accounting prepare and execute Aug 14, 2023
Dronplane
Dronplane approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dronplane Dronplane merged commit 9a0acb8 into master Aug 15, 2023
1 check passed
@Dronplane Dronplane deleted the feature/apm-670 branch August 15, 2023 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dronplane Dronplane Dronplane approved these changes

@gnusi gnusi Awaiting requested review from gnusi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @Dronplane