This repository has been archived by the owner on May 3, 2024. It is now read-only.
Fix some dangerous code #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dronplane
approved these changes
Aug 10, 2023
| // TODO(MBkkt) Change zero meaning | ||
| static constexpr auto kSizeMax = std::numeric_limits<size_t>::max(); | ||
| static constexpr auto kDocsMax = std::numeric_limits<uint32_t>::max() - 2; | ||
| static auto ZeroMax(auto value, auto max) noexcept { |
There was a problem hiding this comment.
We can, at least, make max as real max -1 to save 1 subtraction as this is anyway deep private stuff
There was a problem hiding this comment.
It's compile time substraction
MBkkt
added a commit
that referenced
this pull request
Aug 14, 2023
* Try less memory usage (#516) * Try less memory usage * fixes * Update columnstore2.cpp * Add benchmark * Add benchmark * Add benchmark * Make reserve for wildcard nfa construction (#536) * Fix burst trie UB (#537) * Fix UB * Hotfix for directory resource managment * Try less memory usage (#516) * Try less memory usage * fixes * Update columnstore2.cpp * Add benchmark * Add benchmark * Add benchmark * wip (#543) * wip * wip * wip
MBkkt
added a commit
that referenced
this pull request
Aug 14, 2023
* Try less memory usage (#516) * Try less memory usage * fixes * Update columnstore2.cpp * Add benchmark * Add benchmark * Add benchmark * Make reserve for wildcard nfa construction (#536) * Fix burst trie UB (#537) * Fix UB * Hotfix for directory resource managment * Try less memory usage (#516) * Try less memory usage * fixes * Update columnstore2.cpp * Add benchmark * Add benchmark * Add benchmark * wip (#543) * wip * wip * wip
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.