Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Speedup segmentation #561

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Speedup segmentation #561

merged 3 commits into from
Sep 20, 2023

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Sep 16, 2023

3 ideas:

  1. We don't need to call `std::next(it) multiple time
  2. We don't need next_next
  3. We can simplify check if we rearrange enum

@MBkkt MBkkt changed the base branch from chore/small-improvements to master September 20, 2023 10:13
Dronplane
Dronplane approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@Dronplane Dronplane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBkkt MBkkt merged commit 2350a18 into master Sep 20, 2023
2 of 3 checks passed
@MBkkt MBkkt deleted the segmentation-improvements branch September 20, 2023 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dronplane Dronplane Dronplane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MBkkt @Dronplane