This repository has been archived by the owner on May 3, 2024. It is now read-only.
Separate WaitGroup #572
Merged
Separate WaitGroup #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dronplane
suggested changes
Nov 3, 2023
We don't need "accurate" count. |
Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>
Why we need method that intentionally lies? |
it's not lies |
Dronplane
added a commit
that referenced
this pull request
Nov 21, 2023
* Separate WaitGroup * Update core/utils/wait_group.hpp Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> * Exact count * fix lints --------- Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com>
Dronplane
added a commit
that referenced
this pull request
Nov 23, 2023
* Feature/use nonpriority pool (#570) * new thread pool * fix * wip * add static * attempt to fix compile warning (#569) the compile option `-fsized-deallocation` should only be used for C++ code, but not for C code. otherwise clang warns with the following message: ``` warning: command-line option ‘-fsized-deallocation’ is valid for C++/ObjC++ but not for C ``` * Improve thread pool (#571) * WIP * WIP * WIP * WIP * Update core/utils/async_utils.cpp * Separate WaitGroup (#572) * Separate WaitGroup * Update core/utils/wait_group.hpp Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> * Exact count * fix lints --------- Co-authored-by: Andrei Lobov <andrei.lobov@arangodb.com> * Backport and start * fix * fix datarace * fix build --------- Co-authored-by: Jan <jsteemann@users.noreply.github.com> Co-authored-by: Valery Mironov <32071355+MBkkt@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.