This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
Add parameters for drone camera #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Weixu, I don't see any changes to the simulation implementation in these commits, are no changes required? I believe there were also some changes that needed to be made to the Pi-Puck, e.g., bigger tag size. I think we should have a discussion about how we can keep the hardware and simulation implementations in sync with each other. It will be important not only for the reproducibility of the results in the Science Robotics article, but also for Mostafa when he needs to do the simulation runs and edit the videos. |
|
What you said makes a lot of sense. We need to consider carefully. How about a skype discussion? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters for drone camera: