Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate deviceName if longer than 20 chars #513

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

sujeet01
Copy link
Contributor

Proposed Changes

The deviceName is now truncated to 20 characters for compatibility with Virtio block devices. See Linux Virtio Block header file for reference.

This change was borrowed from the GitLab fork of CSI driver, originally authored by @FlorinPeter. Thanks for the contribution!

@sujeet01 sujeet01 requested a review from a team as a code owner September 27, 2024 08:06
@github-actions github-actions bot added size/XS enhancement New feature or request labels Sep 27, 2024
@sujeet01 sujeet01 self-assigned this Sep 27, 2024
@afritzler afritzler merged commit f42e2a1 into main Sep 27, 2024
11 checks passed
@afritzler afritzler deleted the enh/truncate-devicename branch September 27, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants