Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve stability of test and reducing Duration of Integration Tests Run #245

Closed
wants to merge 7 commits into from
Closed

improve stability of test and reducing Duration of Integration Tests Run #245

wants to merge 7 commits into from

Conversation

so-sahu
Copy link
Contributor

@so-sahu so-sahu commented Mar 20, 2024

Proposed Changes

  • Adding squashfsOSImage for machine boot
  • Removed the extra fields in machine definitions
  • Readjusted the timeouts
  • Used ordered flag

Fixes #242

@so-sahu so-sahu self-assigned this Mar 20, 2024
@so-sahu so-sahu requested a review from a team as a code owner March 20, 2024 07:14
@github-actions github-actions bot added size/L bug Something isn't working server labels Mar 20, 2024
@so-sahu so-sahu added integration-tests to run integration tests bug Something isn't working size/L server and removed bug Something isn't working size/L server labels Mar 20, 2024
@so-sahu so-sahu changed the title reducing integration tests duration Reducing Duration of Integration Tests Run Mar 20, 2024
@so-sahu so-sahu marked this pull request as draft March 20, 2024 07:45
@so-sahu so-sahu marked this pull request as ready for review March 20, 2024 08:01
lukas016
lukas016 requested changes Mar 20, 2024
View reviewed changes
provider/server/machine_delete_test.go Outdated Show resolved Hide resolved
provider/server/server_suite_test.go Outdated Show resolved Hide resolved
provider/server/status_test.go Outdated Show resolved Hide resolved
@lukas016 lukas016 changed the title Reducing Duration of Integration Tests Run improve stability of test and reducing Duration of Integration Tests Run Mar 20, 2024
@lukas016
Copy link
Contributor

check pls this PR https://github.com/ironcore-dev/libvirt-provider/pull/222/files and move DeferCleanup they are in some files on wrong place and they don't have to be running in some cases.

@lukas016 lukas016 mentioned this pull request Mar 20, 2024
Open
@so-sahu so-sahu force-pushed the fix/reduce-integration-test-duration branch from 5ccab8c to 108db08 Compare March 21, 2024 03:16
@lukasfrank
Copy link
Member

@so-sahu Is there a reason for enforcing the ordered execution?

@so-sahu
Copy link
Contributor Author

so-sahu commented Mar 22, 2024

I observed some unexpected behavior, particularly when listing machines with labels. Instead of returning one machine, it returned two. It seems that one test is affecting another. Even @lukas016 has observed such strange behavior.

To address this, I'm using ordered execution.

@so-sahu so-sahu requested a review from lukas016 March 22, 2024 08:45
@lukas016
Copy link
Contributor

our test aren't written for parallel run

lukas016
lukas016 requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are using invalid ignition.

@so-sahu so-sahu force-pushed the fix/reduce-integration-test-duration branch from 460d504 to 997423e Compare March 26, 2024 06:16
@so-sahu so-sahu requested review from lukas016 and lukasfrank March 26, 2024 06:33
lukas016
lukas016 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@lukas016 lukas016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@so-sahu
Copy link
Contributor Author

so-sahu commented Jul 23, 2024

Re-writing of tests in progress: #345

@so-sahu so-sahu closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas016 lukas016 lukas016 approved these changes

@lukasfrank lukasfrank Awaiting requested review from lukasfrank

Assignees

@so-sahu so-sahu

Labels
bug Something isn't working integration-tests to run integration tests server size/L
Projects
Compute
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extended Duration of Integration Tests Run
3 participants
@so-sahu @lukas016 @lukasfrank