Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass serverLabels from MachineClass to ServerClaim #5

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Pass serverLabels from MachineClass to ServerClaim #5

merged 1 commit into from
Jul 22, 2024

Conversation

Nuckal777
Copy link
Contributor

Proposed Changes

  • Pass serverLabels from MachineClass to ServerClaim
  • Remove network and root disk configuration

Fixes #4

@Nuckal777 Nuckal777 requested a review from a team as a code owner July 19, 2024 16:52
@github-actions github-actions bot added documentation Improvements or additions to documentation provider size/L labels Jul 19, 2024
afritzler
afritzler requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nuckal777! Just some minor cosmetic things.

pkg/metal/create_machine_test.go Outdated Show resolved Hide resolved
pkg/metal/testing/testing.go Outdated Show resolved Hide resolved
@afritzler afritzler added the enhancement New feature or request label Jul 22, 2024
@Nuckal777
Pass serverLabels from MachineClass to ServerClaim
4919bd5 
Also remove network and root disk configuration
@Nuckal777 Nuckal777 requested a review from afritzler July 22, 2024 11:27
@afritzler afritzler changed the title Pass serverLabels from MachineClass to ServerClaim Pass serverLabels from MachineClass to ServerClaim Jul 22, 2024
@afritzler afritzler merged commit b9b06c8 into main Jul 22, 2024
9 checks passed
@afritzler afritzler deleted the server-labels branch July 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request provider size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ServerSelector in provider config
2 participants
@Nuckal777 @afritzler