-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styled font weight and response box #25
base: main
Are you sure you want to change the base?
Conversation
border: 1px solid #716f6f; | ||
padding-right: 20px; | ||
padding-left: 5px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(any ideas on how to make the design cleaner?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2,9 +2,9 @@ body, input { | |||
font-size: 17px; | |||
line-height: 27px; | |||
-webkit-font-smoothing: subpixel-antialiased; | |||
font-family:-apple-system-font, BlinkMacSystemFont, 'Helvetica Neue', sans-serif; | |||
font-family:-apple-system, BlinkMacSystemFont, avenir next, avenir, segoe ui, helvetica neue, helvetica, Ubuntu, roboto, noto, arial, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the colors and the design of the "guess" button + textbox!
I fixed the response box background in light mode. I actually considered removing it, that's why it was missing. But I added it again, with a slight different color. I'm afraid I can't do more than that given the limitations I have. A small side note: Noticed you added the 'buy me coffee' paragraph, I think it'll look better to add it right after the לשתף ולחזור לשחק מחר'. The left alignment is a bit messy and confusing and having it as a separate paragraph is a bit too much with the timer. These are my 2 cents about it :P |
Is there anything more I should do/change then? :) |
Changed the response box style to be the same as in the English version.
Changed the fonts weight - numbers and English letters are closer to Hebrew letters.