Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing variables #298

Merged
merged 3 commits into from
Jun 13, 2024
Merged

add missing variables #298

merged 3 commits into from
Jun 13, 2024

Conversation

nirvanagit
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.37%. Comparing base (74cd140) to head (6a96db0).

Files Patch % Lines
admiral/pkg/clusters/handler.go 0.00% 6 Missing ⚠️
admiral/pkg/controller/common/common.go 0.00% 2 Missing ⚠️
admiral/pkg/controller/admiral/controller.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   73.37%   73.37%           
=======================================
  Files          35       35           
  Lines        3670     3670           
=======================================
  Hits         2693     2693           
  Misses        804      804           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nirvanagit nirvanagit merged commit 657f906 into master Jun 13, 2024
3 of 4 checks passed
@nirvanagit nirvanagit deleted the update-variables branch June 13, 2024 23:56
OutlierDetection = "OutlierDetection"
ClientConnectionConfig = "ClientConnectionConfig"

WasmPathValue = "/etc/istio/extensions/dynamicrouter.wasm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need WasmPathValue, AIREnvSuffix,IntuitTID?

Copy link
Collaborator

@vrushalijoshi vrushalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants