Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 disabled test beim wahlvorbereitung-service enablen und implementieren #445

Merged
merged 1 commit into from
Sep 26, 2024
Merged

230 disabled test beim wahlvorbereitung-service enablen und implementieren #445

merged 1 commit into from
Sep 26, 2024

Conversation

dragonfly28
Copy link
Contributor

Beschreibung:

  • TheEntity incl. Repo/Controller/etc. entfernt
  • Flyway-Skripte um Tabelle zu droppen
  • CacheControlConfigurationTest entfernt
  • UnicodeConfigurationTest ebenfalls entfernt, da kein DTO mit Text-Property existiert um dies testen zu können; der String 'wahlbezirkID' wird immer gleichzeitig als ID in der DB benutzt bzw. in der URL verwendet um eine Ressource mit dieser ID anzulegen und ist hier nicht geeignet;

Backend

  • Doku aktualisiert
  • Swagger-API vollständig
  • Unit-Tests gepflegt
  • Integrationstests gepflegt
  • Beispiel-Requests gepflegt

Closes #230

@dragonfly28 dragonfly28 linked an issue Sep 25, 2024 that may be closed by this pull request
Disabled Test beim wahlvorbereitung-service enablen und implementieren #230
Closed
1 task
@dragonfly28 dragonfly28 self-assigned this Sep 25, 2024
@MrSebastian MrSebastian requested review from MrSebastian and removed request for MrSebastian September 25, 2024 15:18
@vjohnslhm vjohnslhm self-requested a review September 26, 2024 10:04
vjohnslhm
vjohnslhm approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@vjohnslhm vjohnslhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht für mich stimmig aus 👍🏽

@dragonfly28 dragonfly28 merged commit 9978677 into dev Sep 26, 2024
3 checks passed
@dragonfly28 dragonfly28 deleted the 230-disabled-test-beim-wahlvorbereitung-service-enablen-und-implementieren branch September 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjohnslhm vjohnslhm vjohnslhm approved these changes

Assignees

@dragonfly28 dragonfly28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled Test beim wahlvorbereitung-service enablen und implementieren
2 participants
@dragonfly28 @vjohnslhm