New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pmd integrations #208

Merged

simonhir merged 47 commits into main from feature/pmd-integrations

Nov 8, 2024

Member

simonhir commented Oct 15, 2024

Description

Setup pmd for integrations and fix warnings.

Reference

Issues closes #57

simonhir added 24 commits

September 20, 2024 08:56


          ➕ gateway add pmd

43f32c7


          ➕ gateway add spotbugs

0c9064a


          🚨 gateway fix pmd and spotbugs findings

5e021db


          🚨 gateway fix pmd findings

0d0d9bf


          👷 ci whitelist spotbugs license

0b4c3ca


          ➕ integrations add pmd and spotbugs

d21e268


          🚨 integrations fix pmd and spotbugs findings

a69649b


          🚨 s3 fix pmd and spotbugs findings

019722f


          🚨 mail fix pmd findings

1e4832f


          Merge branch 'main' into feature/pmd-and-spotbugs

8ae2e62

# Conflicts:
#	refarch-integrations/refarch-s3-integration/refarch-s3-integration-core/src/test/java/de/muenchen/refarch/integration/s3/application/usecase/FileOperationsPresignedUrlUseCaseTest.java
#	refarch-integrations/refarch-s3-integration/refarch-s3-integration-rest/refarch-s3-integration-rest-client/src/test/java/de/muenchen/refarch/integration/s3/client/repository/presignedurl/PresignedUrlRestRepositoryTest.java
#	shared-files/pmd-ruleset.xml


          🐛 s3 integration fix imports

e39cb69


          🎨 integrations format with spotless

c655432


          🚨 s3 fix pmd warnings

9b8085d


          🚨 mail fix pmd warnings

3ec5c4f


          Merge branch 'refs/heads/main' into feature/pmd-and-spotbugs

6d8169b


          🚨 dms fix pmd warnings

bf93a70


          🚨 dms fix pmd warnings

5a85f6a


          🚨 dms fix pmd warnings


          🚨 dms fix pmd warnings

622ea09


          🚨 dms fix pmd warnings

16892ee


          🎨 dms spotless format

9f20e84


          ➖ integrations rm spotbugs

e84eece


          🚨 dms fix pmd warnings

78bb7d9


          Merge branch 'main' into feature/pmd-integrations

060d410

simonhir self-assigned this

simonhir requested a review from a team as a code owner

October 15, 2024 10:30

github-actions bot added Component: Integrations Type: Feature labels

simonhir commented

View reviewed changes

refarch-integrations/pom.xml Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems

View reviewed changes

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
                      val procedureResponse = fabasoftAdapter.createFile(file, "user");

                      final String procedureResponse = fabasoftAdapter.createFile(file, USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String procedureResponse' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
                      val procedureResponse = fabasoftAdapter.createProcedure(procedure, "user");

                      final Procedure procedureResponse = fabasoftAdapter.createProcedure(procedure, USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'Procedure procedureResponse' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

Comment on lines +140 to +141

		final String documentResponse = fabasoftAdapter
		.createDocument(new Document("procedureCOO", "title", LocalDate.parse("2023-12-31"), DocumentType.EINGEHEND, List.of(content)), USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String documentResponse' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

Comment on lines +158 to +159

		final String documentResponse = fabasoftAdapter
		.createDocument(new Document("procedureCOO", "title", LocalDate.parse("2023-12-31"), DocumentType.AUSGEHEND, List.of(content)), USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String documentResponse' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

Comment on lines +176 to +177

		final String documentResponse = fabasoftAdapter
		.createDocument(new Document("procedureCOO", "title", LocalDate.parse("2023-12-31"), DocumentType.INTERN, List.of(content)), USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String documentResponse' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
                      val expectedFile = new Content("extension", "filename", "content".getBytes());

                      final Content expectedFile = new Content(EXTENSION, "filename", CONTENT);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'Content expectedFile' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
            @@ -314,22 +323,22 @@
          
                              SearchObjNameGI.class, (u) -> u.getObjclass().equals(DMSObjectClass.Aktenplaneintrag.getName()),

                              response);

                      val files = fabasoftAdapter.searchSubjectArea("searchString", "user");

                      final List<String> files = fabasoftAdapter.searchSubjectArea("searchString", USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'List<String> files' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

@@ @@ -338,45 +347,48 @@ @@
                               SearchObjNameGI.class, (u) -> u.getObjclass().equals(dmsObjectClass.getName()) && validateBusinessData(u),
                               response);
-                      val files = fabasoftAdapter.searchFile(searchString, user, reference, value);
+                      final List<String> files = fabasoftAdapter.searchFile(searchString, user, reference, value);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'List<String> files' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
                      WiremockWsdlUtility.stubOperation(

                              "ReadMetadataObjectGI",

                              ReadMetadataObjectGI.class, (u) -> true,

                              response);

                      val metadata = fabasoftAdapter.readMetadata("coo", "user");

                      final Metadata metadata = fabasoftAdapter.readMetadata("coo", USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'Metadata metadata' is never read.

.../test/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapterTest.java

    
            @@ -385,9 +397,9 @@
          
                              ReadContentObjectMetaDataGI.class, (u) -> true,

                              response);

                      val metadata = fabasoftAdapter.readContentMetadata("coo", "user");

                      final Metadata metadata = fabasoftAdapter.readContentMetadata("coo", USER);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'Metadata metadata' is never read.


          ⬆️ integrations use pmd module and pmd 3.26

a6acec3

github-actions bot added the Component: Tools label


          ⬆️ integrations pmd use new junit warning names

Member Author

simonhir commented Nov 4, 2024

Waiting for #248

simonhir added 3 commits

November 5, 2024 08:01


          🚨 integrations suppress instead of exclude warnings

c95ce7b


          Merge branch 'main' into feature/pmd-integrations

d9eeac1


          ⬆️ integrations use pmd conf v1.0.1

36ebae2

simonhir marked this pull request as ready for review

November 5, 2024 09:30

Member Author

simonhir commented Nov 5, 2024

The lint warnings should disappear after merge, as the new autobuild mode fixes them.

devtobi self-requested a review

November 6, 2024 12:02

devtobi requested changes

View reviewed changes

refarch-integrations/pom.xml Outdated Show resolved Hide resolved

.../src/main/java/de/muenchen/refarch/integration/dms/adapter/out/fabasoft/FabasoftAdapter.java Show resolved Hide resolved

...gration-core/src/main/java/de/muenchen/refarch/integration/dms/adapter/out/s3/S3Adapter.java Outdated Show resolved Hide resolved

...rc/main/java/de/muenchen/refarch/integration/dms/application/port/in/CancelObjectInPort.java Outdated Show resolved Hide resolved

...on-core/src/main/java/de/muenchen/refarch/integration/dms/domain/exception/DmsException.java Outdated Show resolved Hide resolved

...e/src/main/java/de/muenchen/refarch/integration/s3/configuration/nfcconverter/NfcHelper.java Show resolved Hide resolved

.../src/main/java/de/muenchen/refarch/integration/s3/configuration/nfcconverter/NfcRequest.java Show resolved Hide resolved

...enchen/refarch/integration/s3/application/usecase/FileOperationsPresignedUrlUseCaseTest.java Outdated Show resolved Hide resolved

...enchen/refarch/integration/s3/application/usecase/FileOperationsPresignedUrlUseCaseTest.java Show resolved Hide resolved

...in/java/de/muenchen/refarch/integration/s3/configuration/S3IntegrationAutoConfiguration.java Show resolved Hide resolved

simonhir added 10 commits

November 8, 2024 06:54


          ♻️ pom reorder pmd module

f44fe6e


          ♻️ s3 refactor test instead suppressing

51254c1


          ♻️ s3 use import for assert methods

39b48b7


          ♻️ integrations supress serial for exceptions

51f8c7a


          ♻️ dms use english and use assert instead of suppressing for test

76099b1


          🔥 dms rm unnecessary supress

76d6232


          ♻️ dms use assert instead of suppressing for test

78428d3


          🔥 dms rm unnecessary supress

f35a58e


          ✏️ dms fix class name typo

a6beb1e


          ♻️ integrations supress serial

github-actions bot added the Component: API-Gateway label

simonhir added 5 commits

November 8, 2024 07:44


          Merge branch 'refs/heads/main' into feature/pmd-integrations

ad6385a


          🎨 format spotless

403f76d


          ♻️ dms refactor exception encapsulation

79883a7


          💚 codeql disable js

c26924c


          ♻️ dms refactor exception encapsulation fix test

cda053b

devtobi approved these changes

View reviewed changes

Member

devtobi left a comment

LGTM

simonhir merged commit ce13f94 into main

13 of 14 checks passed

simonhir deleted the feature/pmd-integrations branch

November 8, 2024 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: API-Gateway Component: Integrations Component: Tools Type: Feature