Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact/multi module pmd conf #232

Merged
merged 17 commits into from
Oct 31, 2024
Merged

Refact/multi module pmd conf #232

merged 17 commits into from
Oct 31, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Oct 28, 2024

Description

Move pmd conf to separate module (see https://maven.apache.org/plugins/maven-pmd-plugin/examples/multi-module-config.html) in refarch-libs and add ci for refarch-libs.

Reference

Issue #57, closes #214
Required for #208

@simonhir simonhir self-assigned this Oct 28, 2024
@github-actions github-actions bot added Component: API-Gateway Issues regarding the API Gateway Type: Maintenance The issue contains maintenance work. labels Oct 28, 2024
@simonhir simonhir added the Component: Libs Issues regarding the libs label Oct 28, 2024
@simonhir simonhir marked this pull request as ready for review October 31, 2024 09:52
@simonhir simonhir requested a review from a team as a code owner October 31, 2024 09:52
@simonhir simonhir added Component: Tools Issues regarding the dev tools and removed Component: Libs Issues regarding the libs labels Oct 31, 2024
@simonhir simonhir marked this pull request as draft October 31, 2024 10:07
@simonhir simonhir marked this pull request as ready for review October 31, 2024 14:13
devtobi
devtobi previously approved these changes Oct 31, 2024
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir closed this Oct 31, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit b3a7373 into main Oct 31, 2024
21 of 25 checks passed
@simonhir simonhir deleted the refact/multi-module-pmd-conf branch October 31, 2024 14:27
@simonhir simonhir removed the Component: API-Gateway Issues regarding the API Gateway label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tools Issues regarding the dev tools Type: Maintenance The issue contains maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PMD breaks module build
2 participants