Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/s3 client rm url override #59

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

simonhir
Copy link
Member

Description

S3 client remove override of s3 url via parameter.
Was DigiWF specific and can still be accomplished by not using the starter.

@simonhir simonhir self-assigned this Aug 12, 2024
@simonhir simonhir requested a review from a team as a code owner August 12, 2024 05:52
@simonhir simonhir mentioned this pull request Aug 12, 2024
Copy link
Contributor

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit aec8d69 into main Aug 12, 2024
6 checks passed
@simonhir simonhir deleted the refactor/s3-client-rm-url-override branch August 12, 2024 11:53
@devtobi devtobi added Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants