Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement from and get in get publishers #216

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Implement from and get in get publishers #216

merged 3 commits into from
Oct 20, 2023

Conversation

thomas-introini
Copy link
Contributor

Implementation of from and to query parameters in GET /publishers as asked in #214

@bfabio
Copy link
Member

bfabio commented Oct 20, 2023

@Tomcat88 thanks, for the PR! 🙌

Gonna review it ASAP

bfabio
bfabio previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@bfabio bfabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

main_test.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
@bfabio bfabio merged commit e8dbc18 into italia:main Oct 20, 2023
5 checks passed
@thomas-introini
Copy link
Contributor Author

Thank you guys, now I can say that I've used Go for my own country 😄

@thomas-introini thomas-introini deleted the implement-from-to-get-publishers branch October 20, 2023 13:29
@bfabio
Copy link
Member

bfabio commented Oct 20, 2023

@Tomcat88 now you can say this was one of the times you've used Go for your own country. Looking forward to more 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfabio bfabio bfabio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-introini @bfabio