Cache failures accessing configurations for buckets.

iterate-ch · Nov 8, 2024 · 35dfb14 · 35dfb14
1 parent b0bda2b
commit 35dfb14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/...storage/src/main/java/ch/cyberduck/core/googlestorage/GoogleStorageVersioningFeature.java b/...storage/src/main/java/ch/cyberduck/core/googlestorage/GoogleStorageVersioningFeature.java
@@ -75,6 +75,7 @@ public VersioningConfiguration getConfiguration(final Path file) throws Backgrou
                 throw new GoogleStorageExceptionMappingService().map("Failure to read attributes of {0}", e, bucket);
             }
             catch(AccessDeniedException l) {
+                cache.put(bucket, VersioningConfiguration.empty());
                 log.warn("Missing permission to read versioning configuration for {} {}", bucket, e.getMessage());
                 return VersioningConfiguration.empty();
             }

diff --git a/s3/src/main/java/ch/cyberduck/core/s3/S3VersioningFeature.java b/s3/src/main/java/ch/cyberduck/core/s3/S3VersioningFeature.java
@@ -149,10 +149,12 @@ public VersioningConfiguration getConfiguration(final Path file) throws Backgrou
                 throw new S3ExceptionMappingService().map("Cannot read container configuration", e);
             }
             catch(AccessDeniedException l) {
+                cache.put(bucket, VersioningConfiguration.empty());
                 log.warn("Missing permission to read versioning configuration for {} {}", bucket, e.getMessage());
                 return VersioningConfiguration.empty();
             }
             catch(InteroperabilityException | NotfoundException i) {
+                cache.put(bucket, VersioningConfiguration.empty());
                 log.warn("Not supported to read versioning configuration for {} {}", bucket, e.getMessage());
                 return VersioningConfiguration.empty();
             }