Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of security scoped bookmarks #16560

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Nov 22, 2024

Do not store bookmark data in user defaults causing performance issues.

2024-11-21 17:45:23.423301+0100 0xd2a399   Fault       0x319f83b            58342  0    Mountain Duck: (CoreFoundation) [com.apple.defaults:User Defaults] CFPrefsPlistSource<0x600003ca4600> (Domain: io.mountainduck, User: kCFPreferencesCurrentUser, ByHost: No, Container: (null), Contents Need Refresh: Yes): Attempting to store >= 4194304 bytes of data in CFPreferences/NSUserDefaults on this platform is invalid. This is a bug in Mountain Duck or a library it uses.
Description of keys being set:
b{43}9: string value, approximate encoded size: 2

Description of keys already present:
l{245}x: string value, approximate encoded size: 2464
l{217}e: string value, approximate encoded size: 2428
l{207}g: string value, approximate encoded size: 2416
l{206}e: string value, approximate encoded size: 2416
l{202}t: string value, approximate encoded size: 2412
l{203}t: string value, approximate encoded size: 2412
l{202}t: string value, approximate encoded size: 2408
l{217}s: string value, approximate encoded size: 2400
l{196}x: string value, approximate encoded size: 2400
l{194}s: string value, approximate encoded size: 2368
...
Total keys: 52379 - Average approximate value size: 1657 bytes

@dkocher dkocher added the core label Nov 22, 2024
@dkocher dkocher added this to the 9.1 milestone Nov 22, 2024
@dkocher dkocher self-assigned this Nov 22, 2024
@dkocher dkocher requested a review from a team as a code owner November 22, 2024 07:41
@dkocher dkocher merged commit 4f52cd2 into master Nov 22, 2024
4 checks passed
@dkocher dkocher deleted the bugfix/MD-22597 branch November 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants