Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow retrieval of "" for s3.acl.default. #16576

Closed
wants to merge 2 commits into from
Closed

Allow retrieval of "" for s3.acl.default. #16576

wants to merge 2 commits into from

Conversation

AliveDevil
Copy link
Contributor

No description provided.

@AliveDevil AliveDevil requested a review from a team as a code owner November 25, 2024 09:42
@AliveDevil AliveDevil linked an issue Nov 25, 2024 that may be closed by this pull request
S3 default ACL setting not persisted on Windows and prevents some uploads #16237
Closed
@dkocher dkocher added this to the 9.1 milestone Nov 25, 2024
dkocher
dkocher requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Failure

[INFO]   [msbuild]   1) Failed : Ch.Cyberduck.Core.Preferences.ApplicationPreferencesTests.PersistsEmptyValue()
[INFO]   [msbuild]     Expected: "DONT"
[INFO]   [msbuild]     But was:  null

@dkocher dkocher self-requested a review November 25, 2024 10:15
@AliveDevil
Copy link
Contributor Author

Merged with 2803868

@AliveDevil AliveDevil closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.

S3 default ACL setting not persisted on Windows and prevents some uploads
2 participants
@AliveDevil @dkocher