bugfix: name regex was incorrectly accepting uppercase

iterative · Sep 22, 2023 · ec0ecd5 · ec0ecd5
1 parent 53bb03f
commit ec0ecd5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/gto/constants.py b/gto/constants.py
@@ -42,7 +42,7 @@ def tag_to_name(value):
 
 
 dirname = "[a-z0-9-_./]+"  # improve?
-name = r"[a-z0-9]([a-z0-9-/_]*[A-Za-z0-9])?"
+name = r"[a-z0-9]([a-z0-9-/_]*[a-z0-9])?"
 semver = r"(?P<major>0|[1-9]\d*)\.(?P<minor>0|[1-9]\d*)\.(?P<patch>0|[1-9]\d*)(?:-(?P<prerelease>(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+(?P<buildmetadata>[0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?"
 counter = "?P<counter>[0-9]+"
 name_re = re.compile(f"^{name}$")

diff --git a/tests/test_constants.py b/tests/test_constants.py
@@ -41,6 +41,7 @@ def test_check_name_is_valid(name):
         "model#1",
         "@namespace/model",
         "DVCLive/Model",
+        "model A",
     ],
 )
 def test_check_name_is_invalid(name):