Merge CII DepartmentName and PersonName #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merge CII DepartmentName and PersonName to single value to avoid illegal duplicate of BT-41/BT-56 in xr - rename BT-41/BT-56 cell name in visualization to better represent real meaning of the BT fields.
|
Thank you for your contribution! We will discuss these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BT-41 (Seller_contact_point) and BT-56 (Buyer_contact_point) both map to DepartmentName AND PersonName of the respective "rsm:SupplyChainTradeTransaction/.../ram:DefinedTradeContact node.
This leads to two BT-41/BT-56 nodes in the XR file after transforming a CII containing both DepartmentName and PersonName. Both of these nodes are allowed only one time in XRechnung Version 3.0.2.
The xr-to-pdf.xsl file handles this by displaying every BT-41/BT-56 node, but these duplicates can lead to problems for people who are building their own software on top of this CII to XR transformation (e.g. when generating java objects from the XR or when building your own visualization).
I also suggest changing the german labels on the visualization from "Name" to "Kontaktstelle" as this better represents the meaning of this field.