Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] pos_debt_notebook: fix some bugs #1160

Open
wants to merge 1 commit into
base: 10.0
Choose a base branch
from

Conversation

alexis-via
Copy link
Contributor

  1. create account of debt journal with reconcile=True
  2. When we have demo data, don't create 2 products with same default_code
  3. Partial fix for button "Pay Full Debt" on customer list in POS frontend. The feature triggered by a click on that button is still buggy: in some scenarios, the payment line is not created.

When we have demo data, don't create 2 products with same default_code
Partial fix for button "Pay Full Debt" on customer list in POS frontend (the method is still buggy: there is a second bug to fix here)
Copy link
Contributor

@itpp-bot itpp-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 installable module is updated:

└─ pos_debt_notebook/
   ├─ data/
   |  └─ demo.xml
   ├─ models.py
   └─ static/
      └─ src/
         └─ js/
            └─ pos.js

Not installable modules remain unchanged.

No new features in doc/changelog.rst files of installable modules

sent by ✌️ Odoo Review Bot

@@ -1051,7 +1051,7 @@ odoo.define('pos_debt_notebook.pos', function (require) {
var order = self.pos.get_order();
if (order) {
var lastorderline = order.get_last_orderline();
if (lastorderline === null && self.pos.config.debt_dummy_product_id){
if (lastorderline === undefined && self.pos.config.debt_dummy_product_id){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected use of undefined no-undefined

@alexis-via
Copy link
Contributor Author

One thing that I noticed: the button "Pay Full Debt" on customers list is sometimes buggy, but the button "Pay Full Debt" on the payment screen works fine. Note that the code is not the same for those 2 buttons.

Copy link
Contributor

@Ramil-Mukhametzyanov Ramil-Mukhametzyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via
Thank you for the pull-request. We'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants